-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: A button to edit/make the summary better via PRs.. #146
Comments
Good idea, @dheerajdlalwani! Some options for the button text:
|
I'd like to work on this. I'd like to request some clarification:
|
Awesome! Thank you!
A link at the top of the page would be just fine!
Do let us know if you have any more questions! Also, do add pictures of how the pages look like, whenever you contribute! Thank you! |
I'm having trouble adding a link at the top of the page. This is my code for a test link:
Could you please suggest the appropriate syntax? |
I think you're trying to add the link at the wrong place. Try adding catchup/summary/individual-summary.adoc Line 17 in 7253154
|
Should we reduce the font size of the 'edit' link, @tusharnankani? |
@sushma1031 can you please try reducing the font size and send a screenshot of that? Feel free to send pictures with any other looks that you think work better as well. Cc: @tusharnankani |
Will do! |
Hey Looks good, yeah.
Yes. Also, what do you think if we push the button to the bottom? Something like this at MDN: https://developer.mozilla.org/en-US/docs/Web/javascript |
Sure @tusharnankani , I can try that. It would look similar to this, although here I haven't reduced the font size yet: Also, should I add a message above the link, like in the MDN docs, or is just the link sufficient? cc: @HarshKapadia2 |
I definitely think it is a good idea to add enough context like MDN. What do you think @OurTechCommunity/core? |
Yeah I think adding a section like MDN at the bottom is a nice idea! @sushma1031 can you design something like MDN that you like? We can go ahead from there. Do post a screenshot! |
Let us know if you need any help! |
I'll work on it. |
Sure. Here is a layout you could follow:
Renders like: Improve the content on this page? Edit the summary on GitHub. Want to get more involved? Learn how to contribute. |
Do modify the links to include the correct CatchUp numbers, @sushma1031 ! Thank you for the example, Tushar! |
I'll make sure to include the respective numbers @HarshKapadia2. |
Here's my code:
Let me know if any changes are required. Also, my CSS changes are being ignored by Git, as the summary-style.css is present in the .gitignore file. Could you please let me know what I should do? |
I like how this looks! What do y'all think @OurTechCommunity/core? I think we need to debate on the position of this section. It looks good at the bottom, but I think it should be above the quotes and below the note with the blue icon. (Picture below.) (We might get rid of that note, but that's another issue - we really need to restructure our summary page.)
Summary styles are located in https://github.com/OurTechCommunity/catchup/blob/main/summary/static/css/summary-style.css, so please make your changes in that file. (I think the file that you're referring to is the file that is copied over to |
I was trying to update the wrong file as you pointed out. Thanks for directing me to the right one! |
One second, just realized this is an issue. @sushma1031, please feel free to open a PR. |
Yes, let's place the content above the horizontal rule above the quotes. Would look good hopefully!
Right. Let's figure that out at #113 |
The button can be added here^
Or......
Like NextJS documentation adds it in the footer
The text was updated successfully, but these errors were encountered: