Skip to content
This repository has been archived by the owner on Oct 20, 2022. It is now read-only.

NiFiCluster nodeAnnotations don't match site docs #151

Open
mh013370 opened this issue Nov 4, 2021 · 0 comments
Open

NiFiCluster nodeAnnotations don't match site docs #151

mh013370 opened this issue Nov 4, 2021 · 0 comments
Assignees
Labels
bug Something isn't working community documentation Improvements or additions to documentation
Milestone

Comments

@mh013370
Copy link
Contributor

mh013370 commented Nov 4, 2021

Bug Report

The NiFiCluster.spec.nodeConfigGroup.nodeAnnotations documented here actually map to NiFiCluster.spec.nodeConfigGroup.nifiAnnotations in the custom resource definition.

The name would be more appropriate as nodeAnnotations given its location in the CRD.

source of the problem is here: https://github.com/Orange-OpenSource/nifikop/blob/master/api/v1alpha1/nificluster_types.go#L284

Environment

  • nifikop version: 0.7.1
  • go version: 16
  • Kubernetes version information:
  • Kubernetes cluster kind:

  • NiFi version:

Possible Solution

I've submitted a PR with a related change and renamed NiFiCluster.spec.nodeConfigGroup.nifiAnnotations to NiFiCluster.spec.nodeConfigGroup.nodeAnnotations to match the site documentation.

Additional context
I've submitted a fix for this in #150

@erdrix erdrix self-assigned this Nov 12, 2021
@erdrix erdrix added bug Something isn't working community documentation Improvements or additions to documentation labels Nov 12, 2021
@erdrix erdrix added this to the 0.8.0 milestone Nov 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working community documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants