Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sane default values on missing reg values #13

Open
NiKiZe opened this issue Apr 7, 2021 · 0 comments
Open

Sane default values on missing reg values #13

NiKiZe opened this issue Apr 7, 2021 · 0 comments

Comments

@NiKiZe
Copy link

NiKiZe commented Apr 7, 2021

Is there any specific reason behind not trying to use sane fallback values if registry values is missing?

I could think that this is a good thing if one wants to ensure that all registeryvalues are set. but if all values could have sane defaults maybe that is not needed?

(I have a mission to get openvpn on windows as a service on startup - but not conflict with possible other OpenVPN installations on the same machine, and will have some questions, and PRs incoming to get that working, but ask for some guidance in regards to why some things are in a specific ways)

NiKiZe added a commit to NiKiZe/openvpnserv2 that referenced this issue Apr 15, 2021
Constructing fallback paths from the path of exe, used if any value is missing.
Also construct fallback config if no registry path is found at all

fixes OpenVPN#13

Signed-off-by: Christian Nilsson <[email protected]>
NiKiZe added a commit to NiKiZe/openvpnserv2 that referenced this issue Apr 16, 2021
Simpler handling on registry key enumeration via Linq
Constructing fallback paths from the path of exe, used if any value is missing.
Also construct fallback config if no registry path is found at all

fixes OpenVPN#13

Signed-off-by: Christian Nilsson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant