Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial UI feedback on TeamComments extension. #8

Open
3 tasks done
kfogel opened this issue Oct 4, 2019 · 3 comments
Open
3 tasks done

Initial UI feedback on TeamComments extension. #8

kfogel opened this issue Oct 4, 2019 · 3 comments
Assignees

Comments

@kfogel
Copy link
Member

kfogel commented Oct 4, 2019

Jeff and I went over the TeamComments UI/UX together on Wednesday.

First, change requests:

  • Don't quote the original when writing a reply comment. People can copy-and-paste if they need to. (Reasoning: If we auto-quote, it adds the complication of deciding which wiki markup we want to expose the possibly-non-wiki-fluent user to. <blockquote> is too much, but even simpler stuff might be as well. After some discussion, we decided that it would be better just not to auto-quote. People can copy from original comment if they want to. If they know wiki markup, they can use that to distinguish the quote from their reply; if not, they can just put quoted material in double quotes.)
  • Put some kind of boundary lines around each comment. Keep it minimal, but make the separation clear.
  • Above the comment field, right now it says "Add your comment (Wiki Markup Cheat Sheet)". Change the parenthesized text to lower-case "(wiki syntax help)", reduce its typeface size relative to the "Add your comment" part, and un-bold it (keeping "Add your comment" bold, of course). torque/extensions/TeamComments/includes/TeamCommentsPage.php line 212, btw (I know you would find that quickly, but I happened to go looking myself earlier, so I thought I'd save you the time).

Next, Jeff had some questions:

  • Do comments show up in Recent Changes?
  • Do comments show up in search results?

(Obviously any of us could get the answers, but if you're in there testing anyway it'll be faster for you to get them then for Jeff or me.)

@frankduncan
Copy link
Collaborator

  • Do comments show up in Recent Changes?

Not currently. That's actually a configurable feature of the original comments I removed, so it should be easy to add it back (provided it worked before).

  • Do comments show up in search results?

No. I'm actually curious how one would let mediawiki know that they should. Would be interesting.

frankduncan pushed a commit that referenced this issue Oct 4, 2019
Issue #8: Initial UI feedback on TeamComments extension.
frankduncan pushed a commit that referenced this issue Oct 4, 2019
Issue #8: Initial UI feedback on TeamComments extension.
frankduncan pushed a commit that referenced this issue Oct 4, 2019
Issue #8: Initial UI feedback on TeamComments extension.
@frankduncan
Copy link
Collaborator

Done and on the macfound test server.

@frankduncan
Copy link
Collaborator

I wanted to update on searching and note that I did a bit more research on it. Doing a rebuildall on the site doesn't lead comments to show up in the search cache, and I'm not quickly finding documentation on parserhooks and how to have them render before the search cache is built, much less how to force a search cache update during some specific action (like adding a comment). My next steps would probably be creating a simple parser hook with some known text and playing with/investigating the parameters passed to the hook to see if one of them will lead to the change we want.

This feels like it's a "hours to figure out correct line of code, five seconds to write it" kind of problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants