Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenRarity not updating metadata rank from burned bots #108

Open
925workk opened this issue Dec 12, 2022 · 0 comments
Open

OpenRarity not updating metadata rank from burned bots #108

925workk opened this issue Dec 12, 2022 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@925workk
Copy link

925workk commented Dec 12, 2022

Describe the bug
NFTs that have been sent to burn addresses are not updating in rarity rank updated despite having their metadata updated. Our NFTs collection has a burn mechanic that sends NFTs to the burn address (0xDeadb071ab55db23Aea4cF9b316faa8B7Bd26196). When an NFT is burnt, we then update the metadata and image to reflect that; however the rarity rank does not update. As a result, we have burned bots ranking higher than other NFTs depending on the rarity of their previous metadata.

Information

To Reproduce

  1. Create a collection with various OpenRarity rankings on the Ethereum Mainnet.
  2. Send various NFTs within the collection to the burn address (0xDeadb071ab55db23Aea4cF9b316faa8B7Bd26196)
  3. Delete the attributes metadata of the bots that have been sent to the burn address.
  4. Notice the OpenRarity ranks do not update.

Expected behavior
NFTs that have no attribute metadata within a collection should either not be ranked or ranked at the bottom of a collection in terms of rarity, regardless if it has been sent to a burn address or not. I have uploaded a test collection on Testnet with the exact same metadata as the live collection on Mainnet, and the NFTs with burnt metadata within the Testnet collection are not being ranked, which is what we expect from the Mainnet collection.

Test collection link: https://testnets.opensea.io/collection/pawn-bots-hfbp4rvtvj
Mainnet collection link: https://opensea.io/collection/pawnbots

Screenshots
Pawn Bot 7827 has been sent to the burn address and has the OpenRarity rank of 67, even though its metadata data has been updated and its previously rare attributes were taken away.
Screen Shot 2022-12-12 at 10 19 36 AM

The same NFT on testnet, is not ranked, which is how it should be. (This NFT has NOT been sent to a burn address)
Screen Shot 2022-12-12 at 11 07 39 AM

Pawn Bot 2993 has the exact same metadata as Pawn Bot 7827 but they both have different rarity ranks.
Screen Shot 2022-12-12 at 11 36 09 AM

Environment
OpenSea website, all devices

Additional context
The Mainnet collection on OpenSea shows a total item count of 7,373 in the collection when total total Token count is really 8,888 the difference is due to OpenSea not taking burned NFTs into account.
The Testnet collection shows a total item count of 8,888 in the collection because no NFTs here have been sent to the burn.
It looks like OpenSea is accounting for those being sent to the burn address and removing them from the collection count. If OpenRarity is also ignoring those being sent the burn address, that could be part of the reasoning why it rarity isn't updating on the main collection.

We appreciate any help or insight on this issue. Our team hopes to use OpenRarity as our main source of truth for rarity, and I hope this issue will also help any other projects who may be experiencing similar issues. Thanks!

@925workk 925workk added the bug Something isn't working label Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants