Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request]Support for IC2 fluid reactors #25

Open
panda2134 opened this issue Jul 4, 2016 · 4 comments
Open

[Request]Support for IC2 fluid reactors #25

panda2134 opened this issue Jul 4, 2016 · 4 comments

Comments

@panda2134
Copy link

As the output of an EU reactor is throttled,the fluid reactors have come into use widely.So being able to control them by using a CC computer seems important. It would be great if the support for them is added. I'm happy to open a pull request to do this if you like this idea.

@boq
Copy link
Member

boq commented Jul 4, 2016

What API call do you want to expose? We already do parts of reactor itself: https://github.com/OpenMods/OpenPeripheral-Integration/blob/master/src/main/java/openperipheral/integration/ic2/AdapterReactor.java#L23, but we may have missed something.

Though parts of reactor vessel seem to be plain blocks (so no interaction at all), while others have no public (or even internal) interface - for example, liquid port exposes only fluid handler functions.

@panda2134
Copy link
Author

In TileEntityReactorRedstonePort.java , I found a public method called getReactor,which means that we can interact with the reactor itself by simply calling the method of the redstone port tile .

@panda2134
Copy link
Author

btw,the method returns TileEntity,while that one in TileEntityReactorAccessHatch.java returns IInventory

@boq
Copy link
Member

boq commented Jul 6, 2016

Yeah, I know. But I've asked "What API call", not "What internal method from TE". Using internal method is generally very risky and creates problems with both OpenPeripheral and integrated mod.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants