Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pom.xml to use java 11 #126

Closed
donbourne opened this issue Oct 1, 2024 · 0 comments · Fixed by #127
Closed

Update pom.xml to use java 11 #126

donbourne opened this issue Oct 1, 2024 · 0 comments · Fixed by #127

Comments

@donbourne
Copy link
Member

Trying to build this project with JDK 8 currently fails due to certain dependencies having been built with Java 11. While it's technically possible to build with ...

    <maven.compiler.source>1.8</maven.compiler.source>
    <maven.compiler.target>1.8</maven.compiler.target>

... it makes more sense to build with ...

    <maven.compiler.source>11</maven.compiler.source>
    <maven.compiler.target>11</maven.compiler.target>

... so that people realize immediately that they need at least JDK 11 to build the project.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

update mvn compiler source and target versions to 11 donbourne/sample-getting-started
1 participant
@donbourne