Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a href attributes to headers on the /start page #3262

Closed
mbroz2 opened this issue Jun 30, 2023 · 7 comments · Fixed by #3380 or #3382
Closed

Add a href attributes to headers on the /start page #3262

mbroz2 opened this issue Jun 30, 2023 · 7 comments · Fixed by #3380 or #3382
Assignees
Labels
enhancement Improvements to existing functionality; redesigns

Comments

@mbroz2
Copy link
Member

mbroz2 commented Jun 30, 2023

Although we have links to the tabbed elements on /start (like Releases and Betas), there is currently no way to link directly to a header. For example, there's no way to link to Download package section or the new Develop with Liberty Tools section.

@mbroz2 mbroz2 added the enhancement Improvements to existing functionality; redesigns label Jun 30, 2023
@natalie-bernhard natalie-bernhard added needs discussion Need clarification on deliverables and removed needs discussion Need clarification on deliverables labels Jul 12, 2023
@steven1046
Copy link
Member

steven1046 commented Aug 15, 2023

Can you use https://openliberty.io/start#ide_tools_section and https://openliberty.io/start#downloads-pkg? Edit: now i see that the header covers it up sometimes on load, we should fix that.

@steven1046
Copy link
Member

steven1046 commented Aug 15, 2023

I noticed if you click these links in the same tab, it generally works to scroll to the right place. If you open it in a new tab, it is out of place. I am only having that issue in Chrome though, FF and Safari are good.

@steven1046
Copy link
Member

@mbroz2 do the links above solve the issue?

@mbroz2
Copy link
Member Author

mbroz2 commented Aug 31, 2023

yes, I think it's adequate.

However, it should properly scroll to the correct section, and it would be better if the links were user accessible (aka, today there's no way for a user to be able to get those links, without having web development skills and inspecting the html for the page....aka it would be nice if we did something similar to what we do for headers in docs where we provide the squiggly link icon on hover over.)

@steven1046
Copy link
Member

I agree that the hyperlink icons like we use in the docs like below would help:
image

@steven1046
Copy link
Member

steven1046 commented Sep 6, 2023

While adding hyperlink icons, lets fix the section id names to match the sections better.

@steven1046
Copy link
Member

@SteveSamJacob19 could you center the href anchors on https://draft-openlibertyio.mqj6zf7jocq.us-south.codeengine.appdomain.cloud/start/#getOL a little more vertically like something like this:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment