-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[csharp][generichost] Remove discriminator property #18445
[csharp][generichost] Remove discriminator property #18445
Conversation
Nice improvement, thanks!
|
Kept the discriminator property so de/serialization can still work with libraries other than STJ. Hard coded the value of the discriminator property so we can remove it from the constructor. Reworked the manual tests to compare json instead of classes to be more concise. Also added more manual tests to ensure de/serialization works. I think this is ready to go @wing328 |
* @param model | ||
* @param property | ||
* @return | ||
*/ | ||
private boolean codegenPropertyIsNew(CodegenModel model, CodegenProperty property) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe we should rename it to something like codegenPropertyIsNewOrDiscriminator but that's pretty minor.
fyi, later i may refactor this function into codegen model/property class instead to avoid too many function in default codegen class
Please merge this first #18408
closes #17397
Removes the discriminator because
new Whale("whale")
is redundant. We can just donew Whale()
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master
(upcoming 7.1.0 minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)