Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add isPathAbsolute() function and remove inconsistency in naming #111

Open
IndrajeetPatil opened this issue Apr 15, 2022 · 0 comments
Open
Labels
enhancement New feature or request

Comments

@IndrajeetPatil
Copy link
Member

All other validators follow the same pattern:

  • the underlying check is implemented in function is*() or has*() function
  • the validation is implemented in function validate*() function

Currently, validatePathIsAbsolute() is the only exception that doesn't have a corresponding is*() function.

Also, this function is inconsistent with the naming convention. The names should be:

  • isPathAbsolute()
  • validateIsPathAbsolute()

Maybe this can be rectified by using an alias. That way, this won't be a breaking change.

@IndrajeetPatil IndrajeetPatil added the enhancement New feature or request label Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant