-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1557 building blocks multiselect delete #1580
base: develop
Are you sure you want to change the base?
Conversation
src/MoBi.Presentation/Tasks/Interaction/InteractionTasksForMultipleBuildingBlocks.cs
Outdated
Show resolved
Hide resolved
src/MoBi.Presentation/Tasks/Interaction/InteractionTasksForMultipleBuildingBlocks.cs
Outdated
Show resolved
Hide resolved
src/MoBi.Presentation/Tasks/Interaction/InteractionTasksForMultipleBuildingBlocks.cs
Outdated
Show resolved
Hide resolved
src/MoBi.Presentation/Tasks/Interaction/InteractionTasksForMultipleBuildingBlocks.cs
Outdated
Show resolved
Hide resolved
switch (buildingBlockToRemove) | ||
{ | ||
case EventGroupBuildingBlock eventGroupBuildingBlock: | ||
_interactionTaskContext.Context.AddToHistory(_interactionTasksForEventGroupBuildingBlock.Remove(eventGroupBuildingBlock, eventGroupBuildingBlock.Module, eventGroupBuildingBlock, silent: true)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This probably adds all the remove commands as separate entries in the history. Instead of that, can you add them to a macro command and then add the macro command in the history? You'd probably capture all the commands in the foreach above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a screenshot of the message when there are some building blocks not removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CI build has failed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments
Fixes #1557
Description
Allow deletion of multiple Building Blocks at the same time with multiselect + right click + Delete context menu.
Type of change
Please mark relevant options with an
x
in the brackets.How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Reviewer checklist
Mark everything that needs to be checked before merging the PR.
This change requires a documentation update
above is selectedScreenshots (if appropriate):
Questions (if appropriate):