Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1528 PV BB: New parameter value - add new entry by path #1531

Merged

Conversation

rwmcintosh
Copy link
Member

@rwmcintosh rwmcintosh commented Aug 29, 2024

Fixes #1528 PV BB: New parameter value - add new entry by path
Fixes #1526 PV BB: New parameter value - required columns are not added

Description

Adding the ability to bulk specify paths to add by hand so they don't have to be selected from the available valid paths. On the right is a text edit where users can add new lines by typing or copy/paste

Type of change

Please mark relevant options with an x in the brackets.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires documentation changes (link at least one user or developer documentation issue):
  • Algorithm update - updates algorithm documentation/questions/answers etc.
  • Other (please describe):

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Integration tests
  • Unit tests
  • Manual tests
  • No tests required

Reviewer checklist

Mark everything that needs to be checked before merging the PR.

  • Check if the code is well documented
  • Check if the behavior is what is expected
  • Check if the code is well tested
  • Check if the code is readable and well formatted
  • Additional checks (document below if any)
  • Check if documentation update issue(s) are created if the option This change requires a documentation update above is selected

Screenshots (if appropriate):

image

Questions (if appropriate):

@rwmcintosh rwmcintosh requested a review from Yuri05 August 29, 2024 17:21
@rwmcintosh rwmcintosh self-assigned this Aug 29, 2024
@rwmcintosh rwmcintosh added this to the Version 12 milestone Aug 29, 2024
@rwmcintosh rwmcintosh marked this pull request as ready for review August 29, 2024 17:25
@rwmcintosh rwmcintosh merged commit 2e8b49d into develop Aug 30, 2024
1 check passed
@rwmcintosh rwmcintosh deleted the 1528-pv-bb-new-parameter-value-add-new-entry-by-path branch August 30, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Fixed
2 participants