Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing initSearchControl() with 'disableSearch' - change in data-source-toolbar.component.ts #179

Open
gitpm opened this issue Sep 2, 2024 · 0 comments

Comments

@gitpm
Copy link

gitpm commented Sep 2, 2024

data-source-toolbar.component.ts -> Link -> Line 921

The following code misses a "this.initSearchControl();" after instancing new FormControl on the searchControl - variable

current:
if (changes['disableSearch']) { this.searchControl = new FormControl<string>({ value: '', disabled: this.disableSearch }); }

suggestion:
if (changes['disableSearch']) { this.searchControl = new FormControl<string>({ value: '', disabled: this.disableSearch }); this.initSearchControl(); }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant