-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve connector visualisation #7
Comments
Here are two visualisation variations: (Note that, in this case I think the direction indicator has been rotated an additional 90 degrees from the correct direction due to this experiment not accounting for a change in how its drawn.) (Note also that the wireframe version of the sphere can also partially indicate the direction (related to the value of |
Due to: the interrelated issues; the fact that I now understand the connector direction aspect; and, have a way to manually debug connector direction visualisation (see below) I'll put the connector visualisation aside for now and return to component model loading/display. The following will display an arrow for the connector direction:
|
Connectors have both a position and a direction attribute but the current visualisations (using spheres) only clearly show the position attribute.
Since understanding the direction attribute seems to be important in understanding how connectors work it seems like it would be a good idea to visually indicate the direction of a connector.
(My initial mis-understanding about connector direction was that I thought a connector's direction was always perpendicular to the object to which it was attached (e.g. the geometric normal of PCB) but this is not the case for the board loader.
This was discovered by using a
THREE.ArrowHelper
to visualise the direction of the connector. TheArrowHelper
visualisation shows that the component connector direction runs along (i.e. parallel to) the surface of the board.)I feel like a notched disc/extruded triangle may be a clearer connector visualisation or, at least, adding an arrowhead/cone that protrudes from the current sphere.
I've experimented with some possible direction visualisation approaches but have uncovered some wider issues:
ConnectorHelper
to visualise connectors, see: CouldEagleBrdRenderer.visualizeConnector()
useTHREE.ConnectorHelper()
? #6ConnectorHelper
constructor currently does not receive the connector itself nor connector direction which would be needed in order to be able to indicate the direction in the visualisation.ConnectorHelper
can only be added after all positioning is completed but also that the direction may still be incorrect. By way of comparison, theArrowHelper
visualisation does correctly set the direction, presumably due to the code inArrowHelper.prototype.setDirection()
.)The text was updated successfully, but these errors were encountered: