-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose additional properties on hole/pad connectors #39
Comments
Viewing in the JS Console the Sparkfun
(Note: Not all items in
So, the pad/pin name can be retrieved via:
The parent element (which seems to originate from
So, the associated element name can be retrieved via:
|
Apparently connectors have changed to not be placed on both top and bottom side individually, so it may be unnecessary to specify this in the name with the latest code. |
top and bottom connectors are a premature optimisation. lets just got for a single connector positioned at the mid-plane |
It seems that top/bottom connectors are currently treated differently anyway (only the top hole gets the Eagle-Loader/src/eagle-brd-renderer.js Line 773 in 6c576a7
FWIW it's not immediately obvious if there's any Eagle-related functionality that requires two connectors per hole so until we run into anything I can continue with the practice of treating the top connection as canonical. @dave5 are you able to push your single-connector version of the code? (Assuming I understood you correctly and such a modified version exists.) |
Given the primary goal of this ticket is to expose element & pin names for use with #38 it seems like this doesn't actually require additional functionality as these properties are already exposed. Is there a need to expose these properties by a simpler mechanism than the current approach? i.e.
Note that currently the Given that we didn't already "know" these values were exposed, I wonder if this suggests at some point we need a better way of implementing/documenting what is stored in |
(Oh, I remember now, I wondered if a stackable Arduino shield style-header (e.g. https://www.adafruit.com/product/85) would be a situation where separate top/bottom Connectors might be required.) |
For a given connector (from
.connectHoles
, i.e. holes and pads, as created in._buildDepthHoles()
) we want the following properties exposed (via.userData
):.userData.element
?)Mirrored? or Top/Bottom Layer?[Not to be specifically handled currently (see here).]The text was updated successfully, but these errors were encountered: