Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve running streams metrics #71

Open
anbsky opened this issue Aug 30, 2021 · 0 comments
Open

Improve running streams metrics #71

anbsky opened this issue Aug 30, 2021 · 0 comments
Labels
good first issue Good for newcomers

Comments

@anbsky
Copy link
Collaborator

anbsky commented Aug 30, 2021 •
edited
Loading

Right now it works by calling metrics.StreamsRunning at the start of binary stream request, which is not suitable for HLS as each HLS stream is guaranteed to incur a multitude of requests.

One way to do it could be maintaining a list of clients that request HLS fragments, based on stream URL, and drop them off after a certain timeout.
@anbsky anbsky added the good first issue Good for newcomers label Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@anbsky