-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DEPTH missing? #241
Comments
Thanks Jen. There is a DEPTH parameter in the OG1 vocab collection so at the moment its being recorded under the same attributes as any other PARAM variable e.g in example file float GLIDER_DEPTH(N_MEASUREMENTS) ; If we want additional attributes for this parameter, I guess we would need to have to mention this specifically somewhere else. |
@emmerbodc I did see and use the parameter vocabulary for the depth parameter. The little thing I noticed is that in the param section the manual specifies that parameters have coordinates of time, longitude, latitude and depth. So it seems that depth is inconsistent with the other params. It was easy enough to figure out what to do. This seems to be only a minor inconsistency, but I recommend that later we add a bit about the depth var. The depth attributes will probably spark some discussion and warrant assigning this to 1.X? |
Indeed attribute of depth should/could be discussed? |
agreed in meeting yesterday to add depth in the manual to the co-ordinates section. I'll close this issue when this PR request goes in |
Proponent(s): @jenseva
Moderator: @OceanGlidersCommunity/format-maintainers
Describe the error
It looks like details for a depth variable are missing from the documentation. This variable doesn't fit into the PARAM section as it is one of the coordinate variables. Also, this var has attributes that are unique to it in the spec.
Example
Here are some attributes that I think should be documented:
:_CoordinateAxisType = "Height";
:_CoordinateZisPositive = "down";
:axis = "Z";
:positive = "down";
:reference_datum = "sea-surface";
Potential solution
Add a description for this variable somewhere and specify the attributes for it.
Platforms affected
All
The text was updated successfully, but these errors were encountered: