Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2023-04-RC1: ACTIONX Test Failures #3477

Open
OPMUSER opened this issue Apr 19, 2023 · 1 comment
Open

2023-04-RC1: ACTIONX Test Failures #3477

OPMUSER opened this issue Apr 19, 2023 · 1 comment

Comments

@OPMUSER
Copy link
Contributor

OPMUSER commented Apr 19, 2023

After removing the COORDSYS keyword from several tests, 29 of the 32 tests run (I have not verified the actual results).

ACTIONX_WTMULT fails with the message WTMULT: keyword not supported, however, the keyword is permitted as per:
/home/david/OPM/GitHub/opm-common/src/opm/input/eclipse/Schedule/Action/ActionX.cpp. And the run previously matched the commercial simulator. The manual has the keyword as supported.

ACTIONX_WCONHIST fails with the message The keyword WCONHIST is not supported in the ACTIONX block as the keyword is not listed in ActionX.cpp. Is this correct, or should we add the keyword to ActionX.cpp?

Similary for ACTIONX_WCONINJH, The keyword WCONINJH is not supported in the ACTIONX block as the keyword is not listed in ActionX.cpp. Is this correct, or should we add the keyword to ActionX.cpp?

@bska
Copy link
Member

bska commented Apr 19, 2023

ACTIONX_WTMULT fails with the message WTMULT: keyword not supported, however, the keyword is permitted as per ActionX.cpp

That entry was added in #2906. From a brief glance, it would appear that our WTMULT implementation might possibly do the right thing in an ACTIONX context, but we'd need to look into it more closely to be sure. It's quite possible that we've regressed here.

As for WCONHIST and WCONINJH, those are not supported in an ACTIONX context and more work is needed before we enable the keywords there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants