Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove obsolete deleteChildren when destructing caf::PdmChildArrayField #10450

Closed
magnesj opened this issue Jul 6, 2023 · 1 comment
Closed

Remove obsolete deleteChildren when destructing caf::PdmChildArrayField #10450

magnesj opened this issue Jul 6, 2023 · 1 comment
Labels
PendingRelease Issues is fixed and will be available in next release System Refactoring or build/test system issues. Code improvments not directly affecting the user.
Milestone
Maintenance 2024 ...

Comments

@magnesj
Copy link
Member

magnesj commented Jul 6, 2023

In the destructor of caf::PdmChildArrayField we now delete the objects in the array. Many places we call deleteChildren, but this is not requred.

Identify and remove deleteChildren from destructors of Rim object.s
@magnesj magnesj added the System Refactoring or build/test system issues. Code improvments not directly affecting the user. label Jul 6, 2023
@magnesj magnesj added this to the Maintenance 2023 - Sprint 7 milestone Jul 6, 2023
@magnesj
Copy link
Member Author

magnesj commented Oct 5, 2024

This is now removed from most destructors.

@magnesj magnesj closed this as completed Oct 5, 2024
@github-actions github-actions bot added the PendingRelease Issues is fixed and will be available in next release label Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
PendingRelease Issues is fixed and will be available in next release System Refactoring or build/test system issues. Code improvments not directly affecting the user.
Projects
None yet
Milestone
Maintenance 2024 - Sprint 10
Development

No branches or pull requests
1 participant
@magnesj