Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GetServiceRootUri in the RESTier version of Trippin fails if route prefix is empty #129

Open
nonbob opened this issue Mar 20, 2020 · 1 comment

Comments

@nonbob
Copy link

nonbob commented Mar 20, 2020

I pulled down ODataSamples today and built the RESTier version of the Trippin service. It built out of the box (using VS 2017 on Windows 10 1909), but when I tried to use one of the GET . . ./$ref routes, it blew up in GetServiceRootUri, which doesn't like having an empty route prefix. I patched around it locally. I could offer my workaround as a PR but. . .first I'll have to go dig into the PR history and see what the local standards are.

BTW, I'm very grateful for the GET . . ./$ref examples. Examples of GET . . ./$ref are a bit hard to find - filtering the results one gets when searching for "$ref" on the innertubes (or even on GitHub) can be a bit daunting (I'd be glad for any advice on that)

@nonbob
Copy link
Author

nonbob commented Mar 27, 2020

Upon further investigation, I see that the code in https://github.com/OData/ODataSamples/blob/master/RESTier/Trippin/Trippin/Helpers.cs correctly derives the service root. Perhaps GetServiceRootUri should be using similar code/sharing code?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant