From 70cfb6cd39cb314fd1eafc7818c4229d4dc204ed Mon Sep 17 00:00:00 2001 From: Arne Beer Date: Sat, 17 Aug 2024 21:27:04 +0200 Subject: [PATCH] fix: No html escape in callback arguments --- CHANGELOG.md | 9 +++++---- pueue/src/daemon/callbacks.rs | 1 + 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 9536b51e..9fcb738f 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -35,10 +35,6 @@ Upon updating Pueue, the previous state will be wiped, resulting in a clean slat TLDR: The new task state representation is more verbose but significantly cleaner and fixes some bugs. It breaks compatibility with old states, so ensure there are no important tasks in your queue before updating. You'll also need to recreate groups. -### Fixed - -- Fixed delay after sending process related commands from client. [#548](https://github.com/Nukesor/pueue/pull/548) - ### Change - **Breaking**: Refactor internal task state. Some task variables have been moved into the `TaskStatus` enum, which now enforces various invariants during compile time via the type system. @@ -59,6 +55,11 @@ TLDR: The new task state representation is more verbose but significantly cleane - Add `command` filter to `pueue status`. [#524](https://github.com/Nukesor/pueue/issues/524) [#560](https://github.com/Nukesor/pueue/pull/560) - Allow `pueue status` to order tasks by `enqueue_at`. [#554](https://github.com/Nukesor/pueue/issues/554) +### Fixed + +- Fixed delay after sending process related commands from client. [#548](https://github.com/Nukesor/pueue/pull/548) +- Callback templating arguments were html escaped by accident. [#564](https://github.com/Nukesor/pueue/pull/564) + ## \[3.4.1\] - 2024-06-04 ### Added diff --git a/pueue/src/daemon/callbacks.rs b/pueue/src/daemon/callbacks.rs index 338b025f..5d620eab 100644 --- a/pueue/src/daemon/callbacks.rs +++ b/pueue/src/daemon/callbacks.rs @@ -55,6 +55,7 @@ pub fn build_callback_command( // Init Handlebars. We set to strict, as we want to show an error on missing variables. let mut handlebars = Handlebars::new(); handlebars.set_strict_mode(true); + handlebars.register_escape_fn(handlebars::no_escape); // Add templating variables. let mut parameters = HashMap::new();