-
Notifications
You must be signed in to change notification settings - Fork 643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding https://skillicons.dev to trusted domains #10178
Comments
@lyndaidaii |
Also, is this happening for referenced images inside of readme? |
Related issue: https://github.com/NuGet/Engineering/issues/5625 |
@erdembayar it's not found |
It's only for our internal ref. |
Any updates in this regard? |
@lyndaidaii |
@eventsourcer, is there any reason why you want to include this domain to our readme allowlist? currently, no packages on NuGet.org published readme with this domain. The usage of this domain is very low. |
@lyndaidaii the only reason of using their elegant icons in readmes.
But considering their lack of privacy policy not adding it to allowlist
shall be fine. Thank you.
…On Mon, 30 Sep 2024 at 9:31 PM lyndaidaii ***@***.***> wrote:
@eventsourcer <https://github.com/eventsourcer>, is there any reason why
you want to include this domain to our readme allowlist? currently, no
packages on NuGet.org published readme with this domain. The usage of this
domain is very low.
also, for this domain, it doesn't have a clear privacy policy on their
website. We can't evaluate the privacy term since it doesn't have it.
Unfortunately, we won't add this domain to our allowlist. Please work on
the privacy and security term with domain owner. We could help evaluate it
once this domain has it.
—
Reply to this email directly, view it on GitHub
<#10178 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AWIEQNJTZW37EPAMLV4PEG3ZZGKHXAVCNFSM6AAAAABN65HYCOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOBTHA4TINJXGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Allowing https://skillicons.dev icons to be rendered in readmes.
Examples
The text was updated successfully, but these errors were encountered: