Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding https://skillicons.dev to trusted domains #10178

Open
eventsourcer opened this issue Sep 10, 2024 · 10 comments
Open

Adding https://skillicons.dev to trusted domains #10178

eventsourcer opened this issue Sep 10, 2024 · 10 comments
Assignees
Labels

Comments

@eventsourcer
Copy link

Allowing https://skillicons.dev icons to be rendered in readmes.

Examples

  1. https://skillicons.dev/icons?i=dotnet
  2. https://skillicons.dev/icons?i=docker
@erdembayar
Copy link
Contributor

@lyndaidaii
Could you please take a look into this?

@eventsourcer
Copy link
Author

Also, is this happening for referenced images inside of readme?
My I have an example referencing a packed image from readme?

@erdembayar
Copy link
Contributor

@eventsourcer
Copy link
Author

Related issue: https://github.com/NuGet/Engineering/issues/5625

@erdembayar it's not found

@erdembayar
Copy link
Contributor

Related issue: NuGet/Engineering#5625

@erdembayar it's not found

It's only for our internal ref.

@eventsourcer
Copy link
Author

Related issue: NuGet/Engineering#5625

@erdembayar it's not found

It's only for our internal ref.

Any updates in this regard?

@erdembayar
Copy link
Contributor

@lyndaidaii
Could you please take a look at this issue?

@lyndaidaii
Copy link
Contributor

lyndaidaii commented Sep 24, 2024 via email

@lyndaidaii lyndaidaii self-assigned this Sep 30, 2024
@lyndaidaii
Copy link
Contributor

@eventsourcer, is there any reason why you want to include this domain to our readme allowlist? currently, no packages on NuGet.org published readme with this domain. The usage of this domain is very low.
also, for this domain, it doesn't have a clear privacy policy on their website. We can't evaluate the privacy term since it doesn't have it.
Unfortunately, we won't add this domain to our allowlist. Please work on the privacy and security term with domain owner. We could help evaluate it once this domain has it.

@eventsourcer
Copy link
Author

eventsourcer commented Sep 30, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants