Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cindex equal 0 #61

Open
tcoroller opened this issue Oct 24, 2024 · 4 comments · May be fixed by #62
Open

cindex equal 0 #61

tcoroller opened this issue Oct 24, 2024 · 4 comments · May be fixed by #62

Comments

@tcoroller
Copy link
Collaborator

File "/home/corolth1/torchsurv/src/torchsurv/metrics/cindex.py", line 568, in _p_value_noether
raise ValueError(
ValueError: The standard error of concordance index must be a positive value.

@tcoroller tcoroller linked a pull request Oct 24, 2024 that will close this issue
@melodiemonod
Copy link
Collaborator

Hi @tcoroller ,

I don't think the edits proposed are correct because it would lead to a division by 0 (

(self.cindex - null_value) / cindex_se
).

The se should not be 0. Do you want to give me a reproducible code so I can check the error you got?

@tcoroller
Copy link
Collaborator Author

Sounds good, let me try to do a reproducible example

@tcoroller
Copy link
Collaborator Author

Unless we can do something like:
(self.cindex - null_value) / (cindex_se + eps) ?

@melodiemonod
Copy link
Collaborator

I mean intuitively the c-index standard error should never be 0. I'm curious to know what can can lead to this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants