Skip to content
This repository has been archived by the owner on Jan 12, 2024. It is now read-only.

List file doesn't paginate #22

Open
fieldju opened this issue Jan 8, 2019 · 1 comment
Open

List file doesn't paginate #22

fieldju opened this issue Jan 8, 2019 · 1 comment

Comments

@fieldju
Copy link
Contributor

fieldju commented Jan 8, 2019

I noticed when doing the refactor for STS that the list files code didn't support pagination even though the results are potentially paginated.

I didn't fix the bug?, since it was outside the scope of that PR.

Making an issue for community contribution or for us to not forget.

You can see the result for list file here
http://engineering.nike.com/cerberus-node-client/global.html#ListFileResult

if has_next = true then the next_offset should be used for offset in the next call, standard sql pagination.

I think there are 2 options

  1. make list file paginate and return all files
  2. make list file take in limit and offset and let users paginate
@kyeotic
Copy link
Member

kyeotic commented Jan 9, 2019

I'd vote for 2

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants