Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review: EmuVR WIGUx Extension #16364

Closed
3 of 14 tasks
squishylemon opened this issue Sep 2, 2024 · 7 comments
Closed
3 of 14 tasks

Review: EmuVR WIGUx Extension #16364

squishylemon opened this issue Sep 2, 2024 · 7 comments

Comments

@squishylemon
Copy link

squishylemon commented Sep 2, 2024

Nexus Username

Squishylemon007

Extension URL

https://www.nexusmods.com/site/mods/1031

Game URL

https://www.nexusmods.com/emuvr

Existing Extension URL

No response

New features

Installs mods to the root folder of the game, and supports all kinds of mods for emuvr

Information

  • I confirm the above is accurate

Packaging

  • This extension is packaged correctly

Testing

  • This game extension has been tested

Review Tasks

If a task fails, contact the author to request changes before continuing.

  • Double-check for existing extension
  • Is the extension packaged correctly?
  • Does it install into Vortex?
  • Does it correctly discover the game?
  • Does it successfully install a mod?
  • Does it successfully install a collection?
  • Does the game run correctly with the mods installed? ​

When reviewed and passed, please complete the following tasks:

  • Run the GitHub Actions to add to manifest
  • Contact author
  • Ask Community to enable the Vortex button for the game
  • Update the #vortex-announcements channel on Discord
@IDCs
Copy link
Contributor

IDCs commented Sep 19, 2024

Hey there @squishylemon,

Was just about to start reviewing your extension but noticed that you've hidden it yourself with the following information:

"This mod is currently not supported by the author(s) and/or has issue(s) they are unable to fix yet."

Can you explain the problems you're faced with so I can try to help?

@squishylemon
Copy link
Author

squishylemon commented Sep 22, 2024

@IDCs It was hidden because we did not want to release it until we were verified so then it could have all the functionality on release, The extension works and was quickly tested myself to make sure it installed mods correctly, and Vortex was installing the extension correctly, etc If i need to unhide it, thats 100% ok and can do that (I'll unhide it now as im a little late to respond to stuff, my apologies)

@IDCs
Copy link
Contributor

IDCs commented Oct 1, 2024

Thanks for clarifying @squishylemon - just reviewed the extension and it looks fine.

Not sure if this was intentional, but I can see you've defined a large set of tools to be used in the extension, yet you did not set them as supported tools in the game registration call.

context.registerGame(
  ...
  supportedTools: [], // This should be set to moddingTools instead of an empty array (unless ofc this was intentional?)
  ...

@squishylemon
Copy link
Author

@IDCs No that was not intentional I'll fix that now, Thanks for pointing that out!

@IDCs
Copy link
Contributor

IDCs commented Oct 1, 2024

Let me know once the new version is uploaded to the site and I'll add it to the extensions manifest

@squishylemon
Copy link
Author

@IDCs Just uploaded and removed some unnecessary tools

@IDCs
Copy link
Contributor

IDCs commented Oct 1, 2024

Done, thank you for your contribution!

@IDCs IDCs closed this as completed Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants