This repository has been archived by the owner on Mar 27, 2023. It is now read-only.
优化collapse动画 #399
Closed
优化collapse动画 #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liufei
suggested changes
Dec 10, 2018
| className: PropTypes.string, | ||
| render() { | ||
| const { className, children, active, ...others } = this.props | ||
| delete others.onClick |
There was a problem hiding this comment.
为什么不合适，const的变量都可以增加，为啥不可以删除呢
如果要移除const的对象中的元素如何做？
wjeek
previously approved these changes
Dec 10, 2018
|
测试后问题：
|
…mpression into collapse-animation-273
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #273
** 动画修改影响了侧边栏滚动条的更新，发版前，需要在真实项目中验证没有问题