From 493b0ffeedb7a0e1c4666d08a69bb6ef3be4441d Mon Sep 17 00:00:00 2001 From: Heberto Mayorquin Date: Fri, 19 Apr 2024 15:30:26 -0600 Subject: [PATCH 1/4] add grid spacing and origin_coords to fields --- src/pynwb/ophys.py | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/pynwb/ophys.py b/src/pynwb/ophys.py index bdff47592..a7d4add3f 100644 --- a/src/pynwb/ophys.py +++ b/src/pynwb/ophys.py @@ -43,7 +43,12 @@ class ImagingPlane(NWBContainer): 'manifold', 'conversion', 'unit', - 'reference_frame') + 'reference_frame', + 'grid_spacing', + 'grid_spacing_unit', + 'origin_coords' + 'origin_coords_unit' + ) @docval(*get_docval(NWBContainer.__init__, 'name'), # required {'name': 'optical_channel', 'type': (list, OpticalChannel), # required From c2408a5d9fd8a2c55820c4b0948ebdc273753b80 Mon Sep 17 00:00:00 2001 From: Ryan Ly Date: Wed, 24 Apr 2024 10:30:01 -0700 Subject: [PATCH 2/4] Update ophys.py --- src/pynwb/ophys.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/pynwb/ophys.py b/src/pynwb/ophys.py index a7d4add3f..6f1483079 100644 --- a/src/pynwb/ophys.py +++ b/src/pynwb/ophys.py @@ -46,7 +46,7 @@ class ImagingPlane(NWBContainer): 'reference_frame', 'grid_spacing', 'grid_spacing_unit', - 'origin_coords' + 'origin_coords', 'origin_coords_unit' ) From fe5a84918723e56d86d93efdf2bbc90e8f6513b7 Mon Sep 17 00:00:00 2001 From: Heberto Mayorquin Date: Thu, 25 Apr 2024 09:21:04 -0600 Subject: [PATCH 3/4] add changelog --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 9bffea855..d68185d6d 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -10,6 +10,7 @@ - Support `NWBDataInterface` and `DynamicTable` in `NWBFile.stimulus`. @rly [#1842](https://github.com/NeurodataWithoutBorders/pynwb/pull/1842) - Added support for python 3.12 and upgraded dependency versions. This also includes infrastructure updates for developers. @mavaylon1 [#1853](https://github.com/NeurodataWithoutBorders/pynwb/pull/1853) - Added `mock_Units` for generating Units tables. @h-mayorquin [#1875](https://github.com/NeurodataWithoutBorders/pynwb/pull/1875) and [#1883](https://github.com/NeurodataWithoutBorders/pynwb/pull/1883) +- Added `reference_frame`, `grid_spacing`, `grid_spacing_unit`, `origin_coords`, `origin_coords_unit` to `ImagingPlane` fields @h-mayorquin [#1892](https://github.com/NeurodataWithoutBorders/pynwb/pull/1892) ### Bug fixes - Fix bug with reading file with linked `TimeSeriesReferenceVectorData` @rly [#1865](https://github.com/NeurodataWithoutBorders/pynwb/pull/1865) From 242cc905063d33508c11de089faa3a03a75f250b Mon Sep 17 00:00:00 2001 From: Ryan Ly Date: Thu, 25 Apr 2024 11:45:12 -0700 Subject: [PATCH 4/4] Update CHANGELOG.md --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index e0532392a..650c81443 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -9,7 +9,7 @@ - Support `stimulus_template` as optional predefined column in `IntracellularStimuliTable`. @stephprince [#1815](https://github.com/NeurodataWithoutBorders/pynwb/pull/1815) - Support `NWBDataInterface` and `DynamicTable` in `NWBFile.stimulus`. @rly [#1842](https://github.com/NeurodataWithoutBorders/pynwb/pull/1842) - Added support for python 3.12 and upgraded dependency versions. This also includes infrastructure updates for developers. @mavaylon1 [#1853](https://github.com/NeurodataWithoutBorders/pynwb/pull/1853) -- Added `reference_frame`, `grid_spacing`, `grid_spacing_unit`, `origin_coords`, `origin_coords_unit` to `ImagingPlane` fields. @h-mayorquin [#1892](https://github.com/NeurodataWithoutBorders/pynwb/pull/1892) +- Added `grid_spacing`, `grid_spacing_unit`, `origin_coords`, `origin_coords_unit` to `ImagingPlane` fields. @h-mayorquin [#1892](https://github.com/NeurodataWithoutBorders/pynwb/pull/1892) - Added `mock_Units` for generating Units tables. @h-mayorquin [#1875](https://github.com/NeurodataWithoutBorders/pynwb/pull/1875) and [#1883](https://github.com/NeurodataWithoutBorders/pynwb/pull/1883) - Allow datetimes without a timezone and without a time. @rly [#1886](https://github.com/NeurodataWithoutBorders/pynwb/pull/1886) - No longer automatically set the timezone to the local timezone when not provided. [#1886](https://github.com/NeurodataWithoutBorders/pynwb/pull/1886)