Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Set default identifier to UUID #1917

Closed
3 tasks done
rly opened this issue Jun 13, 2024 · 2 comments
Closed
3 tasks done

[Feature]: Set default identifier to UUID #1917

rly opened this issue Jun 13, 2024 · 2 comments
Labels
category: enhancement improvements of code or code behavior
Milestone

Comments

@rly
Copy link
Contributor

rly commented Jun 13, 2024

What would you like to see added to PyNWB?

The NWB schema says that the identifier should be unique. https://github.com/NeurodataWithoutBorders/nwb-schema/blob/dev/core/nwb.file.yaml#L27-L31

To simplify the creation of an NWB file, I suggest that we set the default identifier to be str(uuid4()). Users can still customize this if they want.

Is your feature request related to a problem?

No response

What solution would you like?

^

Do you have any interest in helping implement the feature?

Yes.

Code of Conduct

@rly rly added the category: enhancement improvements of code or code behavior label Jun 13, 2024
@rly rly added this to the 2.8.0 milestone Jun 13, 2024
@stephprince
Copy link
Contributor

stephprince commented Jun 14, 2024

maybe related to this discussion: #954?

@rly
Copy link
Contributor Author

rly commented Jun 14, 2024

Oh. Oops. That's the same issue and a better resolution, because NWBFile already has an object id. Thanks. I propose we make that potentially breaking change in the API in the next major release.

@rly rly closed this as completed Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: enhancement improvements of code or code behavior
Projects
None yet
Development

No branches or pull requests

2 participants