Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kilosort import syntax errors don't specify filename #890

Closed
dhmjhu opened this issue Jul 2, 2024 · 2 comments
Closed

Kilosort import syntax errors don't specify filename #890

dhmjhu opened this issue Jul 2, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@dhmjhu
Copy link
Contributor

dhmjhu commented Jul 2, 2024

Describe the issue

When trying to import Kilosort data, syntax errors in params.py refer to <string> instead of a real filename.

Trying to import a Kilosort directory with an invalid params.py leads to a message like:

Request Failed
invalid syntax (, line 3)

Screenshot of error message

The above message was not properly escaped (see #889). It should say:

Request Failed
invalid syntax (<string>, line 3)

It would be helpful if the filename containing the syntax error could be displayed instead of <string>. This may affect other formats, but I've only tried it with Kilosort.

Steps to Reproduce

  1. Add a syntax error to an existing Kilosort params.py or use guide-error-example.zip
  2. Create a new conversion pipeline with a "KiloSort Sorting" source format
  3. Select the directory containing the invalid params.py and click "Next"

Operating System

Windows 11 23H2 Enterprise

GUIDE Version

1.0.2

Code of Conduct

Yes

Did you confirm this issue was not already reported?

Yes

@CodyCBakerPhD
Copy link
Collaborator

It would be helpful if the filename containing the syntax error could be displayed instead of . This may affect other formats, but I've only tried it with Kilosort.

This would be helpful, but is not something we would implement on the GUIDE but rather NeuroConv; we have some refactors to source schemas there over the next few months that should make these types of errors a bit more explicit

@CodyCBakerPhD CodyCBakerPhD self-assigned this Jul 29, 2024
@CodyCBakerPhD CodyCBakerPhD added the enhancement New feature or request label Jul 29, 2024
@CodyCBakerPhD
Copy link
Collaborator

Closing for now - once NeuroConv makes these kinds of file assertions, a rebuild of GUIDE should automatically forward them to the visual display

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants