Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat OutputFile fileName attribute as relative to the LEMS file directory #48

Open
JustasB opened this issue Apr 28, 2017 · 4 comments

Comments

@JustasB
Copy link

JustasB commented Apr 28, 2017

Currently, the value in Include tag, file attribute is treated differently from the fileName attribute of OutputFile tag. They should be treated the same way for consistency.

E.g. <Include file="NML2_SingleCompHHCell.nml"/> looks for NML2_SingleCompHHCell.nml in the same folder as the LEMS file.

However, <OutputFile fileName="ex5_v.dat"> writes to ex5_v.dat in the folder from where jnml is being executed, which is not necessarily the same one where the LEMS file is located.

@pgleeson
Copy link
Member

pgleeson commented May 9, 2017

Thanks for pointing this out @JustasB.
I've just noticed that this is not the case with jnml -neuron, only jnml. In the former case the hoc/mod files as well as the generated dat files are created in the folder relative to the LEMS file (were you just referring to models run with jnml?)
I'll look into changing this.

@JustasB
Copy link
Author

JustasB commented May 9, 2017

were you just referring to models run with jnml?<<
Yes, this was happening with jnml alone.

@pgleeson
Copy link
Member

This will require a bit of work on the jlems java code, and will change the behaviour of the application in future for anyone running it from a different directory (though it is more consistent with the nml import & behaviour of jnml -neuron, so probably should be changed).
Can you give me an indication of how urgent this is for your workflow @JustasB?

@JustasB
Copy link
Author

JustasB commented May 16, 2017

Not urgent. I'm using a workaround of cd'ing into the target directory in the meantime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🆕 New
Development

No branches or pull requests

2 participants