EIP 7742 implementation #7518
EIP 7742 implementation #7518
Conversation
yerke26
changed the title
# Conflicts: # src/Nethermind/Nethermind.JsonRpc/Modules/Eth/FeeHistory/FeeHistoryOracle.cs
| @@ -137,7 +137,7 @@ private void SelectBlobTransactions(IEnumerable<Transaction> blobTransactions, B | |||
| checkedBlobTransactions++; | |||
|
|
|||
| ulong txBlobGas = (ulong)(blobTx.BlobVersionedHashes?.Length ?? 0) * _eip4844Config.GasPerBlob; | |||
| if (txBlobGas > _eip4844Config.MaxBlobGasPerBlock - blobGasCounter) | |||
| if (!spec.IsEip7742Enabled && txBlobGas > _eip4844Config.MaxBlobGasPerBlock - blobGasCounter) | |||
There was a problem hiding this comment.
hmmm is this handled correcty?
There was a problem hiding this comment.
same thing here, need to skip the logic related to MaxBlobGasPerBlock
| @@ -405,7 +405,7 @@ private bool ValidateEip4844Fields(Block block, IReleaseSpec spec, out string? e | |||
|
|
|||
| ulong blobGasUsed = BlobGasCalculator.CalculateBlobGas(blobsInBlock); | |||
|
|
|||
| if (blobGasUsed > Eip4844Constants.MaxBlobGasPerBlock) | |||
| if (!spec.IsEip7742Enabled && blobGasUsed > Eip4844Constants.MaxBlobGasPerBlock) | |||
There was a problem hiding this comment.
but if EIP enabled than we do what? I think it is not handled correctly
There was a problem hiding this comment.
Upon activating this EIP (i.e. before processing any transactions), the verification of the blob maximum as given in EIP-4844 can be skipped. Concretely, this means any logic relating to MAX_BLOB_GAS_PER_BLOCK as given in EIP-4844 can be deprecated
This is written in EIP specification, I think if IsEip7742Enabled = true we need to skip this logic
| ulong totalDataGas = BlobGasCalculator.CalculateBlobGas(blobCount); | ||
| return totalDataGas > Eip4844Constants.MaxBlobGasPerTransaction ? TxErrorMessages.BlobTxGasLimitExceeded | ||
| : blobCount < Eip4844Constants.MinBlobsPerTransaction ? TxErrorMessages.BlobTxMissingBlobs | ||
| if (!releaseSpec.IsEip7742Enabled |
There was a problem hiding this comment.
same thing here, need to skip the logic related to MaxBlobGasPerBlock which is equal to MaxBlobGasPerTransaction
| /// </summary> | ||
| [JsonRequired] | ||
| public sealed override WithdrawalRequest[]? WithdrawalRequests { get; set; } | ||
| // [JsonRequired] TODO: should be on ExecutionPayloadV4? |
There was a problem hiding this comment.
Should we ask other core devs?
# Conflicts: # src/Nethermind/Nethermind.Core/Specs/IReleaseSpec.cs # src/Nethermind/Nethermind.Merge.Plugin/Data/ExecutionPayloadV4.cs # src/Nethermind/Nethermind.Merge.Plugin/Handlers/EngineRpcCapabilitiesProvider.cs
Resolves #7526
Changes
removed MAX_BLOB_GAS_PER_BLOCK, TARGET_BLOB_GAS_PER_BLOCK
Get target_blob_count, max_blob_count from Engine Api
added target_blob_count, max_blob_count to ExecutionPayload
added target_blob_count, max_blob_count to BlockHeader
removed verifications related to MAX_BLOB_GAS_PER_BLOCK
used target_blob_count * Eip4844Constants.GasPerBlob instead of TARGET_BLOB_GAS_PER_BLOCK
Types of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?
Notes on testing
Optional. Remove if not applicable.
Documentation
Requires documentation update
If yes, link the PR to the docs update or the issue with the details labeled
docs. Remove if not applicable.Requires explanation in Release Notes
If yes, fill in the details here. Remove if not applicable.
Remarks
Optional. Remove if not applicable.