Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SnsWESAnalysisOutput class not compatible with other sns pipeline outputs #34

Open
stevekm opened this issue Nov 18, 2017 · 2 comments
Open

Comments

@stevekm
Copy link
Member

stevekm commented Nov 18, 2017

Tried to implement sns RNA-Seq pipeline but the SnsWESAnalysisOutput class (from here) has issues with compatibility, due to validation and methods which rely on sns wes specific files.

Need to find a way to refactor so that we can use other types of pipelines

Need to fork the project, leave snsxt as-is, develop new framework that is not tied to sns wes as tightly?

Maybe deprecate many of the methods of analysis objects which are no longer used or needed, and instead implement them as methods of SnsTask objects. In this way, sns attributes will be tied to the individual sns pipelines and not to the analysis object as a whole

@stevekm
Copy link
Member Author

stevekm commented Nov 20, 2017

working on new Analysis and Sample classes for this here
https://github.com/NYU-Molecular-Pathology/snsxt/blob/refactor-analysis-task-classes/snsxt/analysis.py

@stevekm
Copy link
Member Author

stevekm commented Nov 20, 2017

need to offload the old analysis object's validate() method onto the task objects
need to offload qsub log validations to the job manager

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant