Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need running tasks to kill their jobs on error #21

Open
stevekm opened this issue Nov 11, 2017 · 4 comments
Open

Need running tasks to kill their jobs on error #21

stevekm opened this issue Nov 11, 2017 · 4 comments
Assignees

Comments

@stevekm
Copy link
Member

stevekm commented Nov 11, 2017

If a tasks is creating qsub jobs for every sample in an analysis, and one sample causes an exception to be raised, the remaining qsub jobs might not be killed if they are not in the background jobs list yet. Need to look into method for handling this

@stevekm
Copy link
Member Author

stevekm commented Nov 13, 2017

maybe give each task object its own internal job queue to put jobs into and monitor from, and wrap a try ... except around the task running itself, catch if exception is raised and run a task.kill_jobs() method similar to the function used in job_management

@stevekm stevekm self-assigned this Nov 13, 2017
@stevekm
Copy link
Member Author

stevekm commented Nov 14, 2017

confirmed that raising an exception while a task is monitoring its own jobs leads to the jobs being left running after the program exits

@stevekm
Copy link
Member Author

stevekm commented Nov 14, 2017

need to modularize the 'job_management' and maybe add it as a task method

@stevekm
Copy link
Member Author

stevekm commented Nov 16, 2017

convert the job_management module into a JobManager object class, use one for monitoring the pipeline background jobs and add them to each task to monitor jobs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant