[Docs/PTX] Add device tensor map init example #1983
+651
−643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahendriksen
commented
Jul 12, 2024
| ----------------- | ||
|
|
||
| The full code example is included below. The `cuda::ptx` instructions in this | ||
| tutorial have become available in CUDA Toolkit 12.5. |
There was a problem hiding this comment.
Godbolt does not yet have CUDA 12.5, so there is no link here. I didn't want to link to a broken example.
docs/libcudacxx/ptx/examples/device_tensormap_initialization.rst
Outdated
Show resolved
Hide resolved
wmaxey
approved these changes
Jul 24, 2024
miscco
approved these changes
Jul 25, 2024
|
Please don't merge yet. I still have to incorporate some internal feedback. |
gonidelis
reviewed
Sep 14, 2024
docs/libcudacxx/ptx/examples/device_tensormap_initialization.rst
Outdated
Show resolved
Hide resolved
gonidelis
approved these changes
Sep 14, 2024
There were quite a few empty pages. This commit makes sure that navigation makes sense.
Address and tensor map
Co-authored-by: Giannis Gonidelis <[email protected]>
Link to CUDA prog guide to avoid fragmentation.
ahendriksen
force-pushed
the
docs-add-device-tensor-map-init-example
branch
from
68653eb
to
90b6aa8
Compare
|
In the mean time, the code example for on-device tensor map modification has made it into the CUDA programming guide. Instead of duplicating the documentation and code sample, I have linked to the relevant section in the programming guide. The improvements to table of contents and layout are still very much worth it in this PR. I have copied over the fixed links from Bryan van de Ven's PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes #1982
Adds documentation of tensormap modification/initialization on device. Also improves on navigation and table of contents of the cuda::ptx docs.
Checklist