From b81bf37348746692840b41de65bc6f873863edca Mon Sep 17 00:00:00 2001 From: Oliver Holworthy Date: Tue, 17 Oct 2023 13:29:46 +0100 Subject: [PATCH 1/2] Change model call default arg values to None instead of bool vals This fixes an issue with model saving where the concrete function cannot be matched correctly --- merlin/models/tf/models/base.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/merlin/models/tf/models/base.py b/merlin/models/tf/models/base.py index ec1f950e77..af0cb14c7e 100644 --- a/merlin/models/tf/models/base.py +++ b/merlin/models/tf/models/base.py @@ -1798,7 +1798,7 @@ def build(self, input_shape=None): self.built = True - def call(self, inputs, targets=None, training=False, testing=False, output_context=False): + def call(self, inputs, targets=None, training=None, testing=None, output_context=None): """ Method for forward pass of the model. @@ -1820,6 +1820,9 @@ def call(self, inputs, targets=None, training=False, testing=False, output_conte Tensor or tuple of Tensor and ModelContext Output of the model, and optionally the context """ + training = training or False + testing = testing or False + output_context = output_context or False outputs = inputs features = self._prepare_features(inputs, targets=targets) if isinstance(features, tuple): From 77ecc375ced98f196ffe728dda6d50d5de0ca704 Mon Sep 17 00:00:00 2001 From: Oliver Holworthy Date: Tue, 31 Oct 2023 14:10:00 +0000 Subject: [PATCH 2/2] Add linux-amd64-gpu-p100-latest-1 to actionlint config --- .github/actionlint.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/actionlint.yaml b/.github/actionlint.yaml index e0fa30b4bf..f5f4e4c59c 100644 --- a/.github/actionlint.yaml +++ b/.github/actionlint.yaml @@ -3,3 +3,4 @@ self-hosted-runner: labels: - 1GPU - 2GPU + - linux-amd64-gpu-p100-latest-1