Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RMP] Subgraph capabilities across Merlin #1019

Open
8 of 10 tasks
EvenOldridge opened this issue Jun 20, 2023 · 2 comments · Fixed by #1022
Open
8 of 10 tasks

[RMP] Subgraph capabilities across Merlin #1019

EvenOldridge opened this issue Jun 20, 2023 · 2 comments · Fixed by #1022
Assignees
Milestone

Comments

@EvenOldridge
Copy link
Member

EvenOldridge commented Jun 20, 2023

Enable the division and retrieval of sub portions of the graph. Incorporate Subgraph usage throughout all of the merlin framework. The multi stage example needs to be refactored to correctly use subgraph workflows.

  • Update the multi-stage example to include NVTabular workflows for user and item towers

    • Update feast feature store values to use non processed values
    • create subgraphs for nvtabular workflow for feature processing in notebook 1
    • load workflow from notebook 1 into notebook 2 and pull subgraphs from workflow
    • use subgraph workflows to process features in systems graph in notebook 2
  • Create Support for usage of subgraphs in NVTabular

  • Create support for usage of subgraphs in Systems

  • Ensure loading and execution of full notebooks with subgraphs

  • Update the text of the notebook to explain what's happening

  • Update the system diagram in the notebook to show where NVT workflows are executed

@jperez999
Copy link
Collaborator

#1022

@jperez999 jperez999 linked a pull request Jun 27, 2023 that will close this issue
@karlhigley
Copy link
Contributor

karlhigley commented Jul 5, 2023

I don't think this is actually done, since the notebook still needs updates to the text and diagrams. I've added additional tasks to track that work.

@karlhigley karlhigley reopened this Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants