From fd15425bfddb618957452dec7d37763cd1150da7 Mon Sep 17 00:00:00 2001 From: cdeline Date: Mon, 27 Nov 2023 10:52:06 -0700 Subject: [PATCH] Update todo items --- bifacial_radiance/main.py | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/bifacial_radiance/main.py b/bifacial_radiance/main.py index 5eab160b..c720d3e8 100644 --- a/bifacial_radiance/main.py +++ b/bifacial_radiance/main.py @@ -2492,7 +2492,8 @@ def makeScene(self, module=None, sceneDict=None, radname=None, sceneRAD = scene._makeSceneNxR(sceneDict=sceneDict, radname=radname) - # TODO: move appendRadfile logic to SceneObj... + # TODO: deprecate this section in favor of multiple sceneObjs + # if 'appendRadfile' not in sceneDict: appendRadfile = False else: @@ -2513,10 +2514,12 @@ def makeScene(self, module=None, sceneDict=None, radname=None, print( "Radfile APPENDAGE created!") else: scene.radfiles = [sceneRAD] - + #TODO: change appendtoScene kwarg to customObject kwarg. keep appendtoScene as deprecated input if appendtoScene is not None: self.appendtoScene(scene.radfiles[0], customObject = appendtoScene) + # TODO: what's the desired default behavior here? + # Do we append a new scene by default, or overwrite? self.scenes.append(scene) return scene