Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can we remove manic? #484

Open
edwardhartnett opened this issue Sep 13, 2024 · 7 comments
Open

can we remove manic? #484

edwardhartnett opened this issue Sep 13, 2024 · 7 comments
Assignees
Labels
enhancement New feature or request

Comments

@edwardhartnett
Copy link
Contributor

We have a subdirectory:
rrfs-workflow/sorc/manage_externals
/manic/

This seems to be a tool for debugging repository check-ins. I believe this is not part of rrfs-workflow and should not be in this repo.

@BenjaminBlake-NOAA
Copy link
Contributor

@edwardhartnett I tried removing the manic subdirectory, but then the manage_externals/checkout_externals script for retrieving the other codes (ufs-weather-model, UFS_UTILS, UPP, etc.) needed for running the workflow fails. I am not too familiar with manage_externals, but I think manic is needed based on the contents of the checkout_externals script. Do you think it should be removed though?

@MatthewPyle-NOAA
Copy link
Contributor

It seems to be part of the manage_externals package - https://github.com/ESMCI/manage_externals

I think eliminating manic means going away from manage_externals. Which may not be a terrible thing.

@edwardhartnett
Copy link
Contributor Author

What is manage_externals?

@MatthewPyle-NOAA
Copy link
Contributor

Is software that clones the external repositories - really don't know much about it. Has been a part of the short range weather (SRW) app for a long time. Feel like some EMCers years ago didn't like it - felt like it was over engineered for doing something fairly simple (git clone), but the associated configure file makes it easy to check on or change a hash or branch to grab (https://github.com/NOAA-EMC/rrfs-workflow/blob/dev-sci/sorc/Externals.cfg)

@BenjaminBlake-NOAA
Copy link
Contributor

BenjaminBlake-NOAA commented Sep 17, 2024

I would be fine with removing manage_externals and replacing it with a simpler checkout process (we used to use a checkout.sh script) if that is the route we want to go. Global workflow does use manage_externals, but I think they use a system installation of it, and it's not actually contained within the global workflow repository.

@BenjaminBlake-NOAA
Copy link
Contributor

I reached out to Kate and she told me that global workflow no longer uses manage_externals, and they instead use submodules for checking out the codes. I think rrfs-workflow could do the same. It would be simpler than manage_externals and would allow us to remove it. What do you think @edwardhartnett and @MatthewPyle-NOAA ?

@edwardhartnett
Copy link
Contributor Author

We will be transitioning to installing as a versioned package (as with all other software). So submodules will not be needed. See #469 for further discussion.

Seems like after we transition to installation as a package, we can remove manage_externals.

@edwardhartnett edwardhartnett self-assigned this Sep 24, 2024
@edwardhartnett edwardhartnett added the enhancement New feature or request label Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Backlog
Development

No branches or pull requests

3 participants