multiple "xfrd: zone %s written received XFR packet from %s with serial %u to " logged

[ttyS4]

xfrd.c:#L2472 is where this message is logged.

I believe the intention is to log only on the last because of the if statement:
zone->latest_xfr->msg_seq_nr == 0 however there is no { and } it is a naked if statement

Probably only a few uses verbosity level 4 like I do so no one noticed.

[wtoorop]

Hi Tamas, actually I believe this is correct, because the message is logged for every packet that is part of the transfer and that has been written out to the transfer file on disk. Perhaps it would be better to take along the msg_seq_nr in the message though, so you don't see exactly the same message repeated for all the packets that make up the entire transfer.

[ttyS4]

hi Willem,
Oh, okay. So you say that this is intentional? Looking at the code again I tend to agree.

Maybe I should just tune my logging level? I will check and come back.

[jaredmauch]

I also have this same issue in my logs, so perhaps it would be useful to add the message?