Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide how to handle HSM related failures #542

Closed
ximon18 opened this issue Jun 10, 2021 · 2 comments · Fixed by #679
Closed

Decide how to handle HSM related failures #542

ximon18 opened this issue Jun 10, 2021 · 2 comments · Fixed by #679
Labels
hsm Relates to adding HSM support to Krill

Comments

@ximon18
Copy link
Member

ximon18 commented Jun 10, 2021

In the proof-of-concept if a key cannot be generated or the internal key mapping cannot be updated and persisted then Krill will exit. Is this okay, or should Krill retry and if so how often and how fast? If all retries fail should Krill exit or only produce errors in the logs? If failures are retried should we count how often this happens and expose it as a metric? Should failure to sign result in a warning but Krill keeps running, or? What about failure to delete a HSM key or failure to generate random values via the HSM?

@ximon18 ximon18 added the hsm Relates to adding HSM support to Krill label Jun 10, 2021
@ximon18 ximon18 linked a pull request Oct 6, 2021 that will close this issue
@ximon18
Copy link
Member Author

ximon18 commented Oct 6, 2021

For the walking skeleton PR #679 @timbru and I decided that Krill should not fail to start nor should it exit if there is a problem communicating with the HSM, instead we should warn in the logs and a retry with backoff approach has been implemented for connections/requests that fail due to a network timeout or I/O error.

@ximon18
Copy link
Member Author

ximon18 commented Sep 6, 2022

Delivered with the Krill v0.10.0 release.

@ximon18 ximon18 closed this as completed Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hsm Relates to adding HSM support to Krill
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant