Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cookie Consent - Clean up #1171

Open
3 tasks
snmln opened this issue Sep 24, 2024 · 0 comments
Open
3 tasks

Cookie Consent - Clean up #1171

snmln opened this issue Sep 24, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@snmln
Copy link
Contributor

snmln commented Sep 24, 2024

Notes from feedback on original Cookie Consent Form work:

  • Currently, the scripts that check cookies run every time a new page loads which I am not sure if it is necessary.
  • (might be related to 1.) I feel like Layout component is doing too much of cookie-related works, which should not be a part of layout's job. It might be slightly complicated in real life since it is layout's job to decide whether to render a specific component or not. But maybe there is something in the middle ground.
  • Banner and CookieConsent expects different forms for its content, Banner expects html and CookieConsent expects markdown. I am fine with either of them, but we should consolidate them.
  • Consolidate Banner and CookieConsent, wether they both should accept HTML or markdown within config props.
  • Extract Cookie consent functionality from the layout component.
  • Run Cookie validation scripts only when necessary (this might require further discussion to define upper and lower boundary of when is and is not necessary)
@snmln snmln added the enhancement New feature or request label Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant