Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visiting sub-pages within 'Visit a Center' and 'Teach' incorrectly highlight the 'Themes' nav bar item #89

Open
Jeanne-le-Roux opened this issue Jan 4, 2024 · 1 comment

Comments

@Jeanne-le-Roux
Copy link

After clicking on any of the sub-pages under "Visit a Center", "Themes" is highlighted in the nav bar rather than "Visit a Center"
image

E.g. after clicking on 'The Hyperwall', "Themes" is underlined in the top nav bar rather than "Visit a Center". The same thing happens if I click on 'Space for Earth'
image

This behavior also happens in the "Teach" section.
image

Clicking on 'STEM Resources' results in the "Themes" nav bar item to be underlined rather than "Teach"
image

@Jeanne-le-Roux Jeanne-le-Roux changed the title Visiting sub-pages within 'Visit a Center' and 'Teach' incorrectly highlight the 'Theme' nav bar item Visiting sub-pages within 'Visit a Center' and 'Teach' incorrectly highlight the 'Themes' nav bar item Jan 4, 2024
@j08lue j08lue added the bug Something isn't working label Mar 28, 2024
@j08lue
Copy link
Collaborator

j08lue commented Apr 3, 2024

We talked about this today among the engineers yesterday.

The first-off answer is that this is hard for us to fix, since all content items (also those below "Visit a Center" and "Teach") are formally Stories, so they are linked to the /stories overview, which we in the EIC instance override with the nine themes page.

I think we can resolve this issue once we have refactored the EIC instance to use the VEDA UI library for content and individual pages and manage routing, content types, etc on its own. But that is quite some time down the road.

Not sure, but maybe we could as a quick fix hide the /stories route and have "Themes" be a custom page or so, then there would be no hierarchy (in terms of nav) for stories at all.

@aboydnw aboydnw removed the bug Something isn't working label Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants