Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't allow curators to publish data that doesn't fit the data shape we need on the front end #622

Open
heidimok opened this issue May 28, 2024 · 3 comments

Comments

@heidimok
Copy link
Contributor

Issue

We have run into a few issue recently that blocked deployment of CASEI from staging to production. It seems that a common thread is related to data in production that doesn't match the data shape we need in the frontend. When curators add to the MI, sometimes they may input data without knowing the data shape we need. Currently there isn't always much guidance or prevention so they have no idea they are causing the deployment to fail.

#621
#617 - spatial bounds input

Desired Outcome

  • Must: Curators cannot publish data that doesn't fit the data shape we need on the MI
  • Must: Curators get notified of which fields are incorrect
  • Nice to have: Curators are provided with the correct shape/format to make the fix. This would be ideal but there is a workaround which is to review existing published data to see what is the correct input.

#620 - This related issue shows a mockup of what would be ideal from a user experience perspective

@Tammo-Feldmann
Copy link
Contributor

@heidimok , just a quick note here that the most recent issue of deployment for CASEI had a different underlying issue. We ran into two Gateway Timeouts on the backend. The /doi and /instrument endpoints would time out on request. I have discussed with @willemarcel that we will likely need a caching solution for those endpoints in the backend. This doesn't change that we would generally want better validation for a match between frontend and backend types but the current issue ended up not being related.

@heidimok
Copy link
Contributor Author

Oh, thanks for the update here, much appreciated. Do we have an idea of why this timeout issue suddenly happened now whereas it didn't before? I'm just curious from a future perspective.

@heidimok
Copy link
Contributor Author

Update that the immediate issue of deploying from staging to production has been addressed so this issue isn't blocking anything.

But we will leave this issue in the backlog as it remains relevant. While data curators can use the Validate feature on the MI to check their inputs before saving data, there is no reason why the system should allow data to be saved if it's going to break the front end build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants