Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor test for doi generation #572

Open
Tammo-Feldmann opened this issue Sep 27, 2023 · 0 comments
Open

Refactor test for doi generation #572

Tammo-Feldmann opened this issue Sep 27, 2023 · 0 comments

Comments

@Tammo-Feldmann
Copy link
Contributor

Describe the bug
The doi generation test was loading a large fixture that interfered with subsequent tests. I am skipping this test and it needs to be rewritten in a different way that makes sure to clean up the test database after it runs.

To Reproduce
You can go to the feature/canonical-mi-workflow, in test_doi_generation.py you can comment out line 95 which says '@pytest.mark.skip(reason="This fixture is breaking subsequent tests")'. This will re-enable the fixture loading and makes subsequent tests fail.

Expected behavior
Tests should run independently without interfering with later tests. The test_doi_generation test should clean up after itself and ideally load only the data that is necessary for the test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant