Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aerie UI allows upload of a command dictionary when there's a command dictionary with a matching version already uploaded #1451

Open
shaheerk94 opened this issue Sep 4, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@shaheerk94
Copy link

Checked for duplicates

No - I haven't checked

Is this a regression?

No - This is a new bug

Version

develop:15e1e94b

Describe the bug

Not exactly sure what (if anything) is wrong here but here's what just happened:

  1. I had loaded dict v6.0.0.3 into my instance
  2. I made a parcel and uploaded an sasf with that parcel and i saw USER_ commands getting highlighted red
  3. i edited the dict to allow users and uploaded it successfully
  4. the new dict didn't appear, probably because i didn't update the version number. i'm not sure if the upload was actually successful or if it got silently rejected
  5. The sequences that had been loaded with the parcel that had v6.0.0.3 of the cmd dictionary were still linting the user commands as red
  6. i uploaded a new cmd dict with a different version number, made a new parcel, deleted the old sequences and re-uploaded them, and the user commands are now appearing valid

I think the right behavior here would be to either 1) reject command dictionaries if there's one of the same version already uploaded, or 2) if someone uploads a new command dictionary that replaces one already uploaded, all the parcels should get updated to use the new version. I think option 2 is a little less appealing that one, we shouldn't really support command dictionaries that have the same versions but different content, but I'm throwing it out as an option.

Reproduction

I can re-produce this by uploading command dictionaries that have the same version but different content as a version that's already been uploaded.

Logs

No response

System Info

Chrome, on develop branch of aerie-ui and aerie backend +

Severity

Minor

@shaheerk94 shaheerk94 added the bug Something isn't working label Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Todo
Development

No branches or pull requests

1 participant