Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow-ups for Gestalt-DI #659

Open
5 tasks
BenjaminAmos opened this issue May 26, 2022 · 1 comment
Open
5 tasks

Follow-ups for Gestalt-DI #659

BenjaminAmos opened this issue May 26, 2022 · 1 comment
Labels
Enhancement-architectural Enhancement-code quality Javadoc, renaming, reordering of lines of code

Comments

@BenjaminAmos
Copy link
Contributor

Some things that could be improved on after merging #622:

  • All remaining uses of ContextWrapper should be removed
  • Make @Inject in NUI screens use the game context. This could be quite a bit of work.
  • Document the roles of the service registry classes (CoreService, GameConfigurationService, SolGameServiceRegistry etc.)
  • Try to find a better alternative to EventReceiverServiceRegistry. It uses the older getSubtypesOf method, which might be better replaced with newer automatic techniques now provided by gestalt-di.
  • If ModuleManager initialisation fails, try to find a way of exiting gracefully whilst displaying an error.
@BenjaminAmos BenjaminAmos added Enhancement-architectural Enhancement-code quality Javadoc, renaming, reordering of lines of code labels May 26, 2022
@DarkWeird
Copy link
Contributor

Try to find a better alternative to EventReceiverServiceRegistry. It uses the older getSubtypesOf method, which might be better replaced with newer automatic techniques now provided by gestalt-di.

It uses new getSubtypesOf :3
I change behaviour of similar methods from scanning or using reflections cache to use gestalt-di indexing(@Index annotation)

But yeah. I imagine that target usage should be something like injecting some collection with event handlers... But gestalt-di don't generate this code yet. Another throuble - backward injecting(injecting from child beancontexts) is not tested yet.. potentially even work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement-architectural Enhancement-code quality Javadoc, renaming, reordering of lines of code
Projects
None yet
Development

No branches or pull requests

2 participants