Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue with & in merchant key #6

Open
jasminsuljic opened this issue Aug 5, 2020 · 3 comments
Open

Issue with & in merchant key #6

jasminsuljic opened this issue Aug 5, 2020 · 3 comments
Assignees
@ZlatanOmerovic

Comments

@jasminsuljic
Copy link
Contributor

jasminsuljic commented Aug 5, 2020 •
edited
Loading

Is seems that merchant key is not escaped properly
@jasminsuljic jasminsuljic assigned ghost Aug 5, 2020
@jasminsuljic jasminsuljic unassigned ghost Apr 20, 2021
@jasminsuljic
Copy link
Contributor Author

@4050350194 let me know if there are any questions.

@ZlatanOmerovic
Copy link

@jasminsuljic I have tested this against monri_key (formerly pikpaykey), and monri_auth_token, and all the characters were encoded properly, incl. the ampersand &.

Can you give me a sample of your merchant code that causes problems?

ZlatanOmerovic pushed a commit that referenced this issue Apr 28, 2021
Issue with & in merchant key
88bc792 
Decoding all HTML entities in fields: `monri_key` & `monri_auth_token` into their native ASCII values using `htmlspecialchars_decode`.

closes #6
@ZlatanOmerovic
Copy link

ZlatanOmerovic commented Apr 28, 2021 •
edited
Loading

@jasminsuljic Issue resolved. HTML entities were not escaped for monri_key. I also escaped the HTML from monri_auth_token as well.

Because of the previous refactoring from task #16, this issue is fixed by the same PR which resolves the issue: #16, which is in PR #17, with specific commit ID: 88bc792.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ZlatanOmerovic ZlatanOmerovic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ZlatanOmerovic @jasminsuljic