Feat: update features for validator 6.0 #771
Merged
+81
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alessandro100
commented
Oct 22, 2024
| @@ -104,31 +118,32 @@ export const DATASET_FEATURES: DatasetFeatures = { | |||
| fileName: 'levels.txt', | |||
| linkToInfo: 'https://gtfs.org/getting_started/features/pathways/#levels', | |||
| }, | |||
| 'Traversal Time': { | |||
| 'In-station traversal time': { | |||
There was a problem hiding this comment.
TODO: revisit the upper / lower case of the spelling of this key
|
Decided to go with manually adding the
|
|
Preview Firebase Hosting URL: https://mobility-feeds-dev--pr-771-xr0pe191.web.app |
davidgamez
approved these changes
Oct 22, 2024
| fileName: 'frequencies.txt', | ||
| linkToInfo: | ||
| 'https://gtfs.org/getting_started/features/base_add-ons/#frequency-based-service ', | ||
| }, | ||
| }; | ||
|
|
||
| // DEPRECATED FEATURES |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #733
Summary:
Update the Feature keys and links in the frontend to reflect the upcoming validator 6.0 release while also supporting previous versions
Expected behavior:
When going to the feed detail page of any feed, under the "Feature" section, you should be able to click on any of them and it will direct you to the correct gtfs.org page
Testing tips:
Go to any feed detail page, when you click on a feature make sure it maps correctly based on https://github.com/MobilityData/gtfs-validator/blob/master/docs/FEATURES.md
For the deprecated features (as of 6.0) they should navigate to the corresponding updated feature page
Please make sure these boxes are checked before submitting your pull request - thanks!
./scripts/api-tests.shto make sure you didn't break anything