Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ids to gtfs Features #733

Closed
Alessandro100 opened this issue Sep 9, 2024 · 3 comments · Fixed by #771
Closed

Add Ids to gtfs Features #733

Alessandro100 opened this issue Sep 9, 2024 · 3 comments · Fixed by #771
Assignees

Comments

@Alessandro100
Copy link
Contributor

Alessandro100 commented Sep 9, 2024

Gtfs features currently do not have a unique way to identify themselves. We need a way to uniquely identify features so that we can

  • attach and use data with them reliably

We will need to add an id to the gtfs feature table

thoughts

  • should we also add extra data to the features in the db? info url, category.. and in the frontend make an api call to get feature data?
@qcdyx
Copy link
Contributor

qcdyx commented Sep 23, 2024

Clarification: changes should be only on the UI, not the validator. spec team is responsible for manually managing the feature update in NOTICE_MIGRATION.md, then dev team apply changes on the UI.

Tasks:

  • UI should do the mapping between old feature and new feature
  • In the case of splitting features, we add new features
  • individual documentation links to the features in the HTML report -> separate issue

@emmambd
Copy link
Contributor

emmambd commented Oct 1, 2024

Need to review and approve #1812 before working on this so our features list is final

@cka-y cka-y assigned cka-y and unassigned cka-y Oct 2, 2024
@emmambd emmambd removed the blocked label Oct 16, 2024
@emmambd
Copy link
Contributor

emmambd commented Oct 16, 2024

Unblocked. Should use new features as written in https://github.com/MobilityData/gtfs-validator/blob/master/docs/FEATURES.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants