Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up lagrange in pallas_based_plonk #16112

Open
volhovm opened this issue Sep 23, 2024 · 0 comments
Open

Speed up lagrange in pallas_based_plonk #16112

volhovm opened this issue Sep 23, 2024 · 0 comments
Assignees

Comments

@volhovm
Copy link
Member

volhovm commented Sep 23, 2024

Right now lagrange funciton is doing

Array.init domain_size ~f:(fun i ->
    Kimchi_bindings.Protocol.SRS.Fq.lagrange_commitment srs domain_size i )

which is calling the bindings function as many times as the domain size. This is concretely expensive: 150ms for just querying all the lagrange bases.

Alternative suggestion:

  1. Implement this function to query lagrange bases directly from rust side using 1 FFI call (this is already very fast)
  2. Do not read it from the SRS every time, but instead read once and pass as arguments to necessary functions
@volhovm volhovm self-assigned this Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

1 participant